-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Register missing ktlint_disabled_rules in editorConfigProperties #1671
Merged
paul-dingemans
merged 6 commits into
pinterest:master
from
tcrawford-figure:register-ktlint-disabled-rules
Oct 12, 2022
Merged
Register missing ktlint_disabled_rules in editorConfigProperties #1671
paul-dingemans
merged 6 commits into
pinterest:master
from
tcrawford-figure:register-ktlint-disabled-rules
Oct 12, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tnx for fixing this bug. The property indeed needs to be defined. |
4 tasks
Can someone please create a release for this fix? |
The next release is being finalized. It will be released in a couple of weeks. |
still waiting for the release |
@paul-dingemans is there a timeline when this will be released? |
A couple of days, if all goes well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
editorConfigProperties
seemed to be missing the newly createdktlintDisabledRulesProperty
. For any downstream plugins that rely on this value to know what properties are valid for ktlint, they may filter out anything but these properties.Ultimately, this could leads to errors like the following if that's the only editor config override provided:
Or if it's not, I can safely assume that the disabled rules will be ignored if
disabled_rules
aren't provided as well.Currently,
disabled_rules
still works but it spams a lot of messages stating that it is disabled. I find this to be an unpleasant developer experience and also leads to confusion for a developer who is simply switching toktlint_disabled_rules
fromdisabled_rules
only to find that their disabled rules are no longer honored.I did not find an issue reported regarding this issue, but please feel free to link any issues if I missed something.
Checklist
CHANGELOG.md
is updatedIn case of adding a new rule: