Generated .editorconfig contains invalid max_line_length value

[magneticflux-]

Expected Behavior

The default value of the standard max_line_length property is a positive integer or off according to the documentation.

Observed Behavior

When running ktlint generateEditorConfig without any options set, the produced (default) file contains max_line_length = -1. This causes IntelliJ to freak out and try to shrink every line as much as possible (since every line always has more than "-1" characters).

Steps to Reproduce

Run ktlint generateEditorConfig in a new IntelliJ project and use the output.

Your Environment

• Version of ktlint used: 0.48.2
• Relevant parts of the .editorconfig settings: max_line_length
• Name and version (or code for custom task) of integration used (Gradle plugin, Maven plugin, command line, custom Gradle task): N/A
• Version of Gradle used (if applicable): N/A
• Operating System and version: Windows 11

The current editorconfig-related code already parses off values correctly as seen here:

ktlint/ktlint-rule-engine-core/src/main/kotlin/com/pinterest/ktlint/rule/engine/core/api/editorconfig/MaxLineLengthEditorConfigProperty.kt

Line 33 in 2d1ab84

property.sourceValue == "off" -> MAX_LINE_LENGTH_PROPERTY_NONE

but on output it writes the invalid value -1.

Additionally, the documentation mentions the off value here, and incorrectly states that -1 is a valid alternative.

Finally, I found a reference to the invalid -1 value in this issue comment: #659 (comment)

[paul-dingemans]

Most likely this setting has worked in the past for IntelliJ. But at least since IntelliJ IDEA 2022.2 this is indeed not working as expected. As of that the generated .editorconfig should not suggest the value -1 to be used but off.