-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#445 - clean up repo by removing maven #621
#445 - clean up repo by removing maven #621
Conversation
Thanks @jaredsburrows! I verified that after updating to 0.36.0-SNAPSHOT (which has this fix #617), I don't have to make any changes to my gradle files, so it should be safe to start making releases via gradle. |
.editorconfig
Outdated
@@ -13,9 +13,5 @@ insert_final_newline = true | |||
[*.{java,kt,kts,scala,rs,xml,kt.spec,kts.spec}] | |||
indent_size = 4 | |||
|
|||
[{Makefile,*.go}] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems unrelated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted.
.announce
Outdated
@@ -1,44 +0,0 @@ | |||
#!/bin/bash -e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this file is used to update version in README.md and on the ktlint.github.io site.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted
Also maven contains step to automatically create a release notes on Github using chandler tool. |
@Tapchicoma Should we port the maven step/command over to Gradle? |
Yes, would be nice. Then Maven could be removed after test release with Gradle. |
@Tapchicoma Is there a plugin for this? |
As far as I know chandler itself is not maintained anymore. Propose replacement is https://github.com/apps/release-drafter app. No idea though how could it be integrated with Gradle. |
I'm okay without chandler, but the maven steps also include a deploy to GitHub which I'd like to not lose. I had to manually upload and generate the signature. |
This plugin seems to work just fine, might be worth evaluating for the use case here. |
@msfjarvis thank you, will take a look 👍 |
@jaredsburrows could you resolve conflict in Chandler tool could be replaced with plugin proposed by @msfjarvis and I add in a separate PR. So this PR could be merged as is. |
@Tapchicoma done! |
@shashachu
@Tapchicoma