Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fill in sdpMid for local candidates #1833

Closed
youmustrust opened this issue Jun 14, 2021 · 2 comments · Fixed by #2990
Closed

Fill in sdpMid for local candidates #1833

youmustrust opened this issue Jun 14, 2021 · 2 comments · Fixed by #2990

Comments

@youmustrust
Copy link

Summary

ICECandidate generates an empty sdpMid for local candidates. If the remote peer doesn't use sdpMLineIndex for locating a media description, all local candidates generated by Pion would be dropped, possibly leading to connectivity check timeout.

Motivation

N/A

Describe alternatives you've considered

N/A

Additional context

aiortc uses sdpMid alone for locating a media description. Since they don't support peer-reflexive candidates, connectivity check timeout occurs with Pion. For this issue, I opened this PR to make aiortc respect sdpMLineIndex.

@Sean-Der
Copy link
Member

Sean-Der commented Jul 2, 2021

Hey @youmustrust

Sorry for the delay on this, been tackling other issues. aiortc + Pion are able to interop, we do testing on webrtc-echoes

@youmustrust
Copy link
Author

@Sean-Der Oh, sorry. This occurs when ICE lite is enabled.

@Sean-Der Sean-Der added this to the 3.1.0 milestone Aug 1, 2021
@Sean-Der Sean-Der modified the milestones: 3.1.0, 4.0.0 Sep 14, 2021
@Sean-Der Sean-Der removed this from the 4.0.0 milestone May 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants