Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pion cannot connect with Janus without manually specifying Candidates SDPMid #2690

Closed
kenzoi opened this issue Mar 1, 2024 · 3 comments · Fixed by #2990
Closed

Pion cannot connect with Janus without manually specifying Candidates SDPMid #2690

kenzoi opened this issue Mar 1, 2024 · 3 comments · Fixed by #2990
Assignees
Labels
bug Something isn't working difficulty:moderate

Comments

@kenzoi
Copy link

kenzoi commented Mar 1, 2024

Your environment.

  • Version: v4.0.0-beta.9 (tested with v3.2.28 too)
  • Janus: We don't control or have access to the Janus, we connect to a third party provider. (I assume that it is a Janus because they have on offer the line a=ssrc:xxxxxxxxx cname:janus)
  • If it helps gather context I can paste here the offer/answer/candidate.

What did you do?

We receive an Offer which include the candidates. We send an Answer and then send the Candidates with ICE Trickle enabled.

We have two "clients" for this third party provider, one in the browser written in Typescript and one in our Pion stack.

What did you expect?

Connection between the peers.

What happened?

On browser everything works as expected and peers got connected.

On Pion we got an status of connection failed, unless manually specifying SDPMid as the string "a" on each local Candidate.

@Sean-Der Sean-Der added bug Something isn't working difficulty:moderate labels Mar 30, 2024
@JoeTurki
Copy link
Member

JoeTurki commented Jan 3, 2025

Hello, I'm currently working on this issue. any additional details would be greatly appreciated!

If it helps gather context I can paste here the offer/answer/candidate.

Yes, please do!

@JoeTurki JoeTurki self-assigned this Jan 3, 2025
@JoeTurki
Copy link
Member

JoeTurki commented Jan 3, 2025

Alright, I managed to replicate the issue. Pion sends incorrect sdpMLineIndex and sdpMid when connecting to Janus. I'll make a PR to fix this issue tonight!

@kenzoi
Copy link
Author

kenzoi commented Jan 7, 2025

I've moved to another company so I lost access to the project, but I'm glad that you could replicate the issue.
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working difficulty:moderate
Development

Successfully merging a pull request may close this issue.

3 participants