Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added password authentication #452

Merged
merged 4 commits into from
Jul 17, 2020
Merged

Added password authentication #452

merged 4 commits into from
Jul 17, 2020

Conversation

gkuga
Copy link
Contributor

@gkuga gkuga commented Jul 16, 2020

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 22.89%. This pull request decreases coverage by -0.02%.

File Function Base Head Diff
pkg/model/project_static_user.go ProjectStaticUser.Auth -- 0.00% +0.00%

nakabonne
nakabonne reviewed Jul 16, 2020
View reviewed changes
Copy link
Member

@nakabonne nakabonne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except for some nits.

pkg/app/api/authhandler/handler.go Show resolved Hide resolved
pkg/app/api/authhandler/login_handler.go Outdated Show resolved Hide resolved
pkg/app/api/authhandler/login_handler.go Outdated Show resolved Hide resolved
@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 22.87%. This pull request decreases coverage by -0.04%.

File Function Base Head Diff
pkg/model/project_static_user.go ProjectStaticUser.Auth -- 0.00% +0.00%

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 22.87%. This pull request decreases coverage by -0.04%.

File Function Base Head Diff
pkg/model/project_static_user.go ProjectStaticUser.Auth -- 0.00% +0.00%

@nakabonne
Copy link
Member

/lgtm

@nghialv
Copy link
Member

nghialv commented Jul 17, 2020

Thank you. I have just left some nits.

@pipecd-bot pipecd-bot removed the lgtm label Jul 17, 2020
@pipecd-bot
Copy link
Collaborator

GO_LINTER

The golinter build is completed with FAILURE. The build will be triggered again when you push any other commits. Or you can trigger it manually by /golinter trigger command right now.

You can check the build log from here.

@gkuga
Copy link
Contributor Author

gkuga commented Jul 17, 2020

/golinter trigger

@pipecd-bot
Copy link
Collaborator

GO_LINTER

The golinter build is completed with FAILURE. The build will be triggered again when you push any other commits. Or you can trigger it manually by /golinter trigger command right now.

You can check the build log from here.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 22.86%. This pull request decreases coverage by -0.04%.

File Function Base Head Diff
pkg/model/project_static_user.go ProjectStaticUser.Auth -- 0.00% +0.00%

@nghialv
Copy link
Member

nghialv commented Jul 17, 2020

Great Job! Thank you.
/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit 47b4e58 into master Jul 17, 2020
@pipecd-bot pipecd-bot deleted the password branch July 17, 2020 08:18
@pipecd-bot pipecd-bot mentioned this pull request Jul 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nakabonne nakabonne nakabonne left review comments

@nghialv nghialv nghialv left review comments

Assignees
No one assigned
Labels
approved area/api release-note-none size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gkuga @pipecd-bot @nakabonne @nghialv