Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved role protobuf into model #513

Merged
merged 2 commits into from
Jul 22, 2020
Merged

Moved role protobuf into model #513

merged 2 commits into from
Jul 22, 2020

Conversation

gkuga
Copy link
Contributor

@gkuga gkuga commented Jul 22, 2020

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 21.16%. This pull request does not change code coverage.

@nakabonne
Copy link
Member

Thank you.
/lgtm

@nghialv
Copy link
Member

nghialv commented Jul 22, 2020

Make gazelle しないと、BUILD fileに入らないと思います。

@pipecd-bot pipecd-bot removed the lgtm label Jul 22, 2020
@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 21.16%. This pull request does not change code coverage.

@nghialv
Copy link
Member

nghialv commented Jul 22, 2020

/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit 60fce46 into master Jul 22, 2020
@pipecd-bot pipecd-bot deleted the role branch July 22, 2020 05:39
@pipecd-bot pipecd-bot mentioned this pull request Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants