Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor deployment configuration for Kubernetes application #558

Merged
merged 2 commits into from
Jul 29, 2020
Merged

Refactor deployment configuration for Kubernetes application #558

merged 2 commits into from
Jul 29, 2020

Conversation

nghialv
Copy link
Member

@nghialv nghialv commented Jul 29, 2020

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot pipecd-bot requested a review from nakabonne July 29, 2020 07:40
@pipecd-bot pipecd-bot requested a review from stormcat24 July 29, 2020 07:40
pipecd-bot
pipecd-bot reviewed Jul 29, 2020
View reviewed changes
Copy link
Collaborator

@pipecd-bot pipecd-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GO_LINTER

Some issues were detected while linting go source files in your changes.

pkg/config/deployment.go Show resolved Hide resolved
nghialv
nghialv commented Jul 29, 2020
View reviewed changes
pkg/config/deployment.go
// e.g. "Deployment/deployment-name", "ReplicaSet/replicaset-name"
Workloads []K8sResourceReference `json:"workloads"`
// Which method should be used for traffic routing.
TrafficRouting *TrafficRouting `json:"trafficRouting"`
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

メインとしてはこれらの変更です。

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 20.77%. This pull request increases coverage by 0.04%.

File Function Base Head Diff
pkg/app/piped/executor/kubernetes/traffic.go findTrafficRoutingManifests -- 0.00% +0.00%
pkg/config/deployment.go DetermineTrafficRoutingMethod -- 0.00% +0.00%
pkg/app/piped/executor/kubernetes/baseline.go Executor.generateBaselineManifests 0.00% 0.00% +0.00%
pkg/app/piped/executor/kubernetes/canary.go Executor.generateCanaryManifests 0.00% 0.00% +0.00%
pkg/app/piped/executor/kubernetes/primary.go Executor.generatePrimaryManifests 0.00% 0.00% +0.00%
pkg/app/piped/executor/kubernetes/traffic.go Executor.ensureTrafficRouting 0.00% 0.00% +0.00%
pkg/app/piped/executor/kubernetes/traffic.go findIstioVirtualServiceManifests 0.00% 0.00% +0.00%
pkg/app/piped/executor/kubernetes/traffic.go Executor.findTrafficRoutingManifests 0.00% -- +-0.00%
pkg/config/deployment.go ParseVariantResourceReference 0.00% -- +-0.00%

nakabonne
nakabonne reviewed Jul 29, 2020
View reviewed changes
pkg/app/piped/executor/kubernetes/baseline.go Outdated Show resolved Hide resolved
pkg/app/piped/executor/kubernetes/canary.go Outdated Show resolved Hide resolved
pkg/app/piped/executor/kubernetes/primary.go Outdated Show resolved Hide resolved
@nghialv @nakabonne
Apply suggestions from code review
1e7137e 
Co-authored-by: Ryo Nakao <ryo@nakao.dev>
@nakabonne
Copy link
Member

/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nakabonne.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 20.77%. This pull request increases coverage by 0.04%.

File Function Base Head Diff
pkg/app/piped/executor/kubernetes/traffic.go findTrafficRoutingManifests -- 0.00% +0.00%
pkg/config/deployment.go DetermineTrafficRoutingMethod -- 0.00% +0.00%
pkg/app/piped/executor/kubernetes/canary.go Executor.generateCanaryManifests 0.00% 0.00% +0.00%
pkg/app/piped/executor/kubernetes/primary.go Executor.generatePrimaryManifests 0.00% 0.00% +0.00%
pkg/app/piped/executor/kubernetes/traffic.go Executor.ensureTrafficRouting 0.00% 0.00% +0.00%
pkg/app/piped/executor/kubernetes/traffic.go findIstioVirtualServiceManifests 0.00% 0.00% +0.00%
pkg/app/piped/executor/kubernetes/baseline.go Executor.generateBaselineManifests 0.00% 0.00% +0.00%
pkg/app/piped/executor/kubernetes/traffic.go Executor.findTrafficRoutingManifests 0.00% -- +-0.00%
pkg/config/deployment.go ParseVariantResourceReference 0.00% -- +-0.00%

@pipecd-bot pipecd-bot merged commit dfd4dbe into master Jul 29, 2020
@pipecd-bot pipecd-bot deleted the config branch July 29, 2020 07:58
@pipecd-bot pipecd-bot mentioned this pull request Jul 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pipecd-bot pipecd-bot pipecd-bot left review comments

@nakabonne nakabonne nakabonne left review comments

@stormcat24 stormcat24 Awaiting requested review from stormcat24

Assignees
No one assigned
Labels
approved area/piped release-note-none size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nghialv @pipecd-bot @nakabonne