Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Gitlab and Bitbucket to make dir URL #613

Merged
merged 1 commit into from
Aug 13, 2020
Merged

Conversation

nakabonne
Copy link
Member

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #597

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 21.50%. This pull request increases coverage by 0.01%.

File Function Base Head Diff
pkg/git/url.go MakeDirURL 93.75% 94.12% +0.37%

@nghialv
Copy link
Member

nghialv commented Aug 13, 2020

/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit 2bba1b8 into master Aug 13, 2020
@pipecd-bot pipecd-bot deleted the more-git-hosts branch August 13, 2020 04:08
@pipecd-bot
Copy link
Collaborator

TEMPLATE

failed to handle template rule examples

Details
Error: unabled to push rendered files to destination

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support more git host
3 participants