Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the layout of deployment cell in list page #650

Merged
merged 2 commits into from
Aug 18, 2020

Conversation

cakecatz
Copy link
Contributor

What this PR does / why we need it:
image

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 21.27%. This pull request does not change code coverage.

@pipecd-bot pipecd-bot added size/M and removed size/S labels Aug 18, 2020
@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 21.27%. This pull request does not change code coverage.

@nghialv
Copy link
Member

nghialv commented Aug 18, 2020

Thank you.
/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@nghialv nghialv changed the title Change status icon position for deployment item Update the layout of deployment cell in list page Aug 18, 2020
@pipecd-bot pipecd-bot merged commit 705b378 into master Aug 18, 2020
@pipecd-bot pipecd-bot deleted the status-icon-position branch August 18, 2020 08:38
@pipecd-bot
Copy link
Collaborator

TEMPLATE

failed to handle template rule examples

Details
Error: unabled to push rendered files to destination

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants