Prototype terraform deployment #652
Conversation
|
A Kapetanios build has just been triggered to run docker operations for the following
|
|
/cc @nakabonne |
| PredefinedStageTerraformApply = "TerraformApply" | ||
| PredefinedStageCloudRunSync = "CloudRunSync" | ||
| PredefinedStageRollback = "Rollback" | ||
| PredefinedStageK8sSync = "K8sSync" |
There was a problem hiding this comment.
exported const PredefinedStageK8sSync should have comment (or a comment on this block) or be unexported
| } | ||
| } | ||
|
|
||
| func (t *Terraform) Changes(ctx context.Context) ([]byte, error) { |
There was a problem hiding this comment.
ctx is unused in Changes
| return nil, nil | ||
| } | ||
|
|
||
| func (t *Terraform) Apply(ctx context.Context) error { |
There was a problem hiding this comment.
ctx is unused in Apply
| return executor.DetermineStageStatus(sig.Signal(), originalStatus, status) | ||
| } | ||
|
|
||
| func (e *Executor) ensureSync(ctx context.Context) model.StageStatus { |
There was a problem hiding this comment.
ctx is unused in ensureSync
| return model.StageStatus_STAGE_SUCCESS | ||
| } | ||
|
|
||
| func (e *Executor) ensurePlan(ctx context.Context) model.StageStatus { |
There was a problem hiding this comment.
ctx is unused in ensurePlan
| return model.StageStatus_STAGE_SUCCESS | ||
| } | ||
|
|
||
| func (e *Executor) ensureApply(ctx context.Context) model.StageStatus { |
There was a problem hiding this comment.
ctx is unused in ensureApply
| return model.StageStatus_STAGE_SUCCESS | ||
| } | ||
|
|
||
| func (e *Executor) ensureRollback(ctx context.Context) model.StageStatus { |
There was a problem hiding this comment.
ctx is unused in ensureRollback
|
The Kapetanios build to run docker operations for the following 1. dockers/piped-base - successAn image named piped-base:0.0.6-f35c0ef was procuded for reviewing and testing. All tests inside this directory have |
| return model.StageStatus_STAGE_SUCCESS | ||
| } | ||
|
|
||
| func (e *Executor) findTerraform(ctx context.Context, version string) (*provider.Terraform, error) { |
There was a problem hiding this comment.
findTerraform is unused, but are you planning to use it later?
There was a problem hiding this comment.
Yes, It will be used later.
Co-authored-by: Ryo Nakao <ryo@nakao.dev>
|
A Kapetanios build has just been triggered to run docker operations for the following
|
|
The Kapetanios build to run docker operations for the following 1. dockers/piped-base - successAn image named piped-base:0.0.6-d8de11f was procuded for reviewing and testing. All tests inside this directory have |
|
Code coverage for golang is
|
|
Looks great! |
|
This pull request is APPROVED by Approvers can cancel the approval by writing |
What this PR does / why we need it:
This is just a part of the prototype.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: