Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update single sign on form #669

Merged
merged 1 commit into from
Aug 20, 2020
Merged

Update single sign on form #669

merged 1 commit into from
Aug 20, 2020

Conversation

cakecatz
Copy link
Contributor

What this PR does / why we need it:

  • Support updated API for RBAC config
  • Show toasts when updated username/password

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 20.59%. This pull request does not change code coverage.

@nghialv
Copy link
Member

nghialv commented Aug 20, 2020

/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit 45b9c5c into master Aug 20, 2020
@pipecd-bot pipecd-bot deleted the update-sso-setting branch August 20, 2020 12:11
@pipecd-bot
Copy link
Collaborator

TEMPLATE

failed to handle template rule examples

Details
Error: unabled to push rendered files to destination

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants