Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor auth by adding GitHub Enterprise provider #703

Merged
merged 3 commits into from
Aug 26, 2020
Merged

Refactor auth by adding GitHub Enterprise provider #703

merged 3 commits into from
Aug 26, 2020

Conversation

gkuga
Copy link
Contributor

@gkuga gkuga commented Aug 26, 2020

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot pipecd-bot added size/L and removed size/M labels Aug 26, 2020
@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 20.94%. This pull request decreases coverage by -0.00%.

File Function Base Head Diff
pkg/oauth/github/github.go newGHEOAuthClient -- 0.00% +0.00%
pkg/model/project.go ProjectSSOConfig.GenerateAuthCodeURL 0.00% 0.00% +0.00%
pkg/model/project.go ProjectSSOConfig_GitHub.GenerateAuthCodeURL 0.00% 0.00% +0.00%
pkg/oauth/github/github.go NewOAuthClient 0.00% 0.00% +0.00%

@nghialv nghialv changed the title Refactor by adding GitHub Enterprise provider Refactor auth by adding GitHub Enterprise provider Aug 26, 2020
@nghialv
Copy link
Member

nghialv commented Aug 26, 2020

Thank you.
/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit 91cd0de into master Aug 26, 2020
@pipecd-bot pipecd-bot deleted the auth branch August 27, 2020 00:00
@pipecd-bot
Copy link
Collaborator

TEMPLATE

failed to handle template rule examples

Details
Error: unabled to push rendered files to destination

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants