External fonts don't work - Upgrade to PhantomJS 2

[davemackintosh]

If you're using web fonts, from say Google Fonts they won't appear because there is no wait for resources to finish loading before rendering the image.

Is there any fix for this?

[shakiba]

Probably a page load listener should be added before rendering. If it is possible for you please check if you can fix it, otherwise I will try to fix it as soon as I'm free.

[davemackintosh]

I'm looking to add support for the load event right now in a fork. Will submit a PR when done.

https://github.com/newworldcode/svgexport
http://www.w3.org/TR/SVG11/interact.html#LoadEvent

[shakiba]

That's great, thanks!

[davemackintosh]

Well.. What a waste of time that was.. It just turns out that it doesn't support fonts very well.. Need to update to PhantomJS 2.0

http://stackoverflow.com/questions/23404658/how-can-i-use-google-web-fonts-with-phantomjs

[davemackintosh]

Working on an update.

[davemackintosh]

💥 Got Phantom 2.0 working and fonts are fixed. Will be submitting a PR once the tests are fixed.

[davemackintosh]

@shakiba

[shakiba]

@davemackintosh Thanks, I have been resisting to upgrade to phantomjs 2.0 for a while, but it seems that this time I can not! Please give me just few days.

[davemackintosh]

How come you've resisted updating?

[shakiba]

The main phantomjs npm package is not upgraded to v2 yet and this issue is still open. I just checked the phantomjs2 npm package, it does not support Windows yet. I will use it in an alpha version, because otherwise svgexport won't be usable in Windows.

[davemackintosh]

Looks like that issue has been closed and updated, I think this PR is outdated now that 2.1 is out. I will revisit in the next few days to update the PR.

[shakiba]

@davemackintosh Thanks, I appreciate your help. It seems that the package name is also changed to phantomjs-prebuilt.