Actually return an error for unknown symbol #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`quote.Get` of an inexistent symbol should return a non nil error.
This does not happen....
To repro ask for a quote from a un-existant symbol:
```golang
package main
import (
"fmt"
"github.com/piquette/finance-go/quote"
)
func main() {
q, err := quote.Get("FOOAASDADSAS")
if err != nil {
panic(err)
}
fmt.Printf("RegulardMarketPrice: %# +v", q.RegularMarketPrice)
}
```
This will panic:
```
$ go run .
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x50 pc=0x620b2e]
goroutine 1 [running]:
main.main()
/home/pallotron/projects/example/ticker-quote.go:14 +0x2e
exit status 2
[Exit code 1 @ 10:12:01]
```
`get.Quote` should return an error in this case.
|
Hello? Can you review this please? :) |
|
@ackleymi Could you merge this? This is the only error I encounter with this library so far and I think many people would be happy if they don't get a panic and a error instead. |
|
this project is very active :D |
Seems abandoned. |
|
Is there any forks maintained? |
|
@pallotron Please feel free to bring this change to my fork, https://github.com/sunglim/yh-finance-go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
quote.Getof an inexistent symbol should return a non nil error.This does not happen....
To repro ask for a quote from a un-existant symbol:
This will panic:
get.Quoteshould return an error in this case.