Fix build process: conflicting dependencies #1013
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* package.json listed grunt ^0.4.5, which conflicts with grunt-nw-builder (requires grunt ^1.0.1). * Node versions 7 and above deprecated os.tmpDir, which is used in several dependencies such as temp (outdated deps?) To patch this, run 'npm install' as usual, then execute the shell script 'patch_tmpdir.sh' in the root of this repo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes building piskel (using
grunt desktop).When building normally, grunt will show
which causes the tasks defined after to not be registered:
This is caused by outdated dependencies relying on
os.tempDir, which was deprecated in Node 7.To fix this, just run
patch_tempdir.shat the root of this repo every time after you runnpm install.Basically, it recurses through node_modules and replaces
os.tempDirwithos.tempdir.