Fix frame-preview-toggle when moving a frame #945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The hiddenFrames list is not updated correctly when a frame is moved. Unmoved frames are mapped incorrectly and result in "undefined" entries in the list, and the resuling list is left unsorted. Make sure unmoved entries still return a value when mapping and sort the list after frames have moved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hiddenFrames list is not updated correctly when a frame is moved.
Unmoved frames are mapped incorrectly and result in "undefined" entries
in the list. The resulting list is also left unsorted. Changed to make unmoved
entries still return a value when mapping and sorted the list after frames
have moved.