Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: get rid x32 wheels #5

Closed
menshikh-iv opened this issue May 4, 2020 · 1 comment · Fixed by #6
Closed

Proposal: get rid x32 wheels #5

menshikh-iv opened this issue May 4, 2020 · 1 comment · Fixed by #6

Comments

@menshikh-iv
Copy link
Contributor

Idea

I propose to remove x32 wheel building. IMO this just spends time and rarely used now (we are in 2020, who still using x32? This is my personal assumtion)

Pros:

  • Twice faster build (because of twice fewer jobs) -> twice fast release (wheel building + testing are the slowest part, @mpenkov can confirm)
  • No x32-related hacks (typical lack of RAM on some tests)

Cons:

  • x32 users affected (and we don't know how much, idk ways to evaluate them)

Examples of other libraries

Doesn't build x32:

Still build x32:

@mpenkov @piskvorky thoughts?

@piskvorky
Copy link
Owner

piskvorky commented May 4, 2020

I'm in favour of removing x32. I didn't even know we had it.

IMO, the only relevant wheels are for (modern) Windows. All other installations can either compile themselves easily (unix), or expect pain anyway (ancient systems).

And if Windows wheels give us too much trouble, we could drop even that. I'd prefer not to, but it's conceivable. Gensim is open source and we cannot afford the project to become too annoying/costly to us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants