Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests that exercise the version pins in setup.py #2913

Open
mpenkov opened this issue Aug 7, 2020 · 0 comments
Open

Add tests that exercise the version pins in setup.py #2913

mpenkov opened this issue Aug 7, 2020 · 0 comments
Labels
housekeeping internal tasks and processes

Comments

@mpenkov
Copy link
Collaborator

mpenkov commented Aug 7, 2020

I personally feel it's OK (and even beneficial) for fresh gensim releases to require fairly-recent releases of those libraries

Yes, upgrading numpy is not a problem. I'd expect our tests to fail though. I'm pretty sure we were testing against the oldest lib, explicitly, but with all the recent changes to the testing framework (azure etc) it's possible that fell through the cracks. We should put it back if possible, @mpenkov WDYT?

Originally posted by @piskvorky in #2899 (comment)

@mpenkov mpenkov added the housekeeping internal tasks and processes label Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping internal tasks and processes
Projects
None yet
Development

No branches or pull requests

1 participant