Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ask travis-ci.com for more credits #3233

Closed
mpenkov opened this issue Sep 14, 2021 · 7 comments
Closed

Ask travis-ci.com for more credits #3233

mpenkov opened this issue Sep 14, 2021 · 7 comments
Assignees
Labels
housekeeping internal tasks and processes

Comments

@mpenkov
Copy link
Collaborator

mpenkov commented Sep 14, 2021

Sounds like RaReTech ran out of Travis credits again:

https://app.travis-ci.com/github/RaRe-Technologies/gensim/requests

Owner RaRe-Technologies does not have enough credits.

Can you please ask them for more? It's not urgent, we only need travis for aarch64 wheel builds, and we can deal with them later, but it'd be good to have that working soon.

@mpenkov mpenkov added the housekeeping internal tasks and processes label Sep 14, 2021
@piskvorky
Copy link
Owner

piskvorky commented Sep 14, 2021

Oh wow. OK, I'll write to the Travis support again.

@gojomo
Copy link
Collaborator

gojomo commented Sep 17, 2021

Earlier this month, Travis-CI had a bug where anyone's PR against a project could potentially access the project's build secret environment-variables:

https://arstechnica.com/information-technology/2021/09/travis-ci-flaw-exposed-secrets-for-thousands-of-open-source-projects/

I see that we do have two project secrets there - WHEELHOUSE_UPLOADER_USERNAME & WHEELHOUSE_UPLOADER_SECRET. I'm not sure of their significance, but I'd guess knowing them might allow someone to replace our wheels in downstream places like AWS or PyPI.

I'm not sure if we had any PRs/builds that could have been affected, giving others access to these credentials, but it'd probably be wise to rotate those secrets to new values as soon as practical, and double-check that any uploads at places controlled by those values are exactly those intended by Gensim authorized users/processes.

@piskvorky
Copy link
Owner

piskvorky commented Sep 18, 2021

Thanks for the heads up. @mpenkov do we actually still need Travis CI? That article is not a flattering, the Travis security response looks like a shit show.

Github actions (Microsoft) might not be that much safer, but at least it's just one service, not two.

@mpenkov
Copy link
Collaborator Author

mpenkov commented Sep 18, 2021

@mpenkov do we actually still need Travis CI?

We use TravisCI for aarch64 wheel builds. Github actions does not support that platform yet.

In our case, TravisCI never runs for PRs (other from the original contributor of the aarch64 code), so it's likely the other PRs were unable to take advantage of the vulnerability even if they wanted to.

but I'd guess knowing them might allow someone to replace our wheels in downstream places like AWS or PyPI.

In practice, leaked AWS credentials would give an attacker access to our AWS account. They could use AWS services and we'd have to pay for that usage (bad). They wouldn't be able to affect PyPI wheels: that's a completely different system.

We do have our (my) PyPI creds in github action secrets for smart_open, for easier releases.

@mpenkov
Copy link
Collaborator Author

mpenkov commented Sep 18, 2021

I'm not sure if we had any PRs/builds that could have been affected, giving others access to these credentials, but it'd probably be wise to rotate those secrets to new values as soon as practical, and double-check that any uploads at places controlled by those values are exactly those intended by Gensim authorized users/processes.

Good idea. @piskvorky Can you rotate the AWS keys? From memory, the account belongs to RaRe.

@piskvorky
Copy link
Owner

piskvorky commented Sep 19, 2021

@piskvorky Can you rotate the AWS keys?

I cannot find it. Is there any way to check which key / user / org the Github secret uses?

EDIT: OK, I found something. @mpenkov AWS key & secret should be updated in Github secrets – can you please check that everything works? Anything else needed?

@mpenkov
Copy link
Collaborator Author

mpenkov commented Sep 28, 2021

I've restarted https://app.travis-ci.com/github/RaRe-Technologies/gensim/builds/237867011.

Once it completes successfully (in around 20 min or so), we can close this ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping internal tasks and processes
Projects
None yet
Development

No branches or pull requests

3 participants