Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement seek over HTTPS #331

Closed
mpenkov opened this issue Jun 22, 2019 · 4 comments
Closed

Implement seek over HTTPS #331

mpenkov opened this issue Jun 22, 2019 · 4 comments

Comments

@mpenkov
Copy link
Collaborator

mpenkov commented Jun 22, 2019

with smart_open.open("https://cs.nyu.edu/~roweis/data/nips12raw_str602.tgz", "rb") as fin:
    fin.seek(0)

raises "UnsupportedOperation: seek"

smart_open 1.8.3

@piskvorky
Copy link
Owner

How could we support seek over gzip? Sounds very tricky.

@mpenkov
Copy link
Collaborator Author

mpenkov commented Jun 22, 2019

We're not actually seeking over gzip. The above code is seeking over raw bytes.

@piskvorky
Copy link
Owner

piskvorky commented Jun 22, 2019

Aha. We don't recognize .tgz as a compressed format? (shorthand for .tar.gz)

Not sure if seek over http(s) is implemented (apparently not) – is this a bug-report ticket or a feature-request ticket? :)

@mpenkov mpenkov changed the title Unable to seek over HTTPS Implement seek over HTTPS Jun 22, 2019
@mpenkov
Copy link
Collaborator Author

mpenkov commented Jun 22, 2019

Yes, we don't.

I'll reword the ticket as a feature request, that way someone may feel more inclined to act on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants