Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue #39: strict null check in tool/unwap #40

Merged
merged 1 commit into from
Sep 17, 2021
Merged

Fix issue #39: strict null check in tool/unwap #40

merged 1 commit into from
Sep 17, 2021

Conversation

tom-tan
Copy link
Member

@tom-tan tom-tan commented Sep 17, 2021

It fixes #39.
Thanks @mr-c!

@tom-tan tom-tan requested a review from inutano September 17, 2021 02:10
@tom-tan tom-tan merged commit 12ef32b into develop Sep 17, 2021
@tom-tan tom-tan deleted the struct-check-unwrap branch September 17, 2021 02:32
@tom-tan tom-tan mentioned this pull request Sep 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mr-c mr-c mr-c left review comments

@inutano inutano inutano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unwrap should test for strict (in)equality with null, not for "falsey"ness
3 participants
@tom-tan @inutano @mr-c