Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundling/configuring k8s resources like Ingress, PVCs, etc. #12

Closed
aegershman opened this issue Jul 24, 2019 · 1 comment
Closed

Bundling/configuring k8s resources like Ingress, PVCs, etc. #12

aegershman opened this issue Jul 24, 2019 · 1 comment

Comments

@aegershman
Copy link

Wanted to comment on this pull request about installation without cluttering up a legit conversation

Apologies for interjecting, but I presume the reason the nginx-ingress chart isn't being suggested as an alternative to raw k8s manifests is because it requires helm, which otherwise wouldn't be a requirement since pb uses duffle for deployments?

The only reason I bring it up is because I imagine having people push plain k8s manifests described in this README.md might to lead to drift or confusion, especially with upcoming k8s API deprecations and whatnot and such.

It might be worth considering, at some point, how an Ingress Controller / Ingress (or any collection of k8s resources) could be optionally packaged/versioned/leveraged/etc. From my very limited understanding of duffle, I wonder if those resources could be packaged with the duffle bundle and be (optionally) leveraged by users if they didn't want to manage an Ingress / Ingress Controller / PVC / etc. separately?

Again, don't mean to be obnoxious with unsolicited opinions, just figured I'd share. Obviously zero expectation to respond to this comment, feel free to close this whenever, etc.

@thisisnotashwin
Copy link

thisisnotashwin commented Jul 24, 2019

@aegershman I think this is really valuable feedback and we really appreciate you helping us. Currently, we expect users to bring their own ingress controller and we weren't too keen on providing raw k8s manifests(which we did get rid of in favor of a link to pivotal docs which walks through the setup of an ingress controller/service). Presently we are trying to limit the scope of build service but we do see a lot of value in a CNAB bundle that could be used to get an ingress controller up and running.

We want to avoid getting into the business of maintaining documentation on things that aren't build service.

I think the idea of a duffle bundle to install an ingress controller and service is a really great one but would probably be best managed by the PCFS team. We could pair with them initially to help them get bootstrapped but it would be great if we weren't the team responsible for maintaining it.

PVCs are a different situation as it is something you need to configure your k8s cluster with. But I think your point still stands. Let us know if the updates made to the PR are ones that are valuable ones and feel free to open new issues or follow up on existing ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants