Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python/mypy linting broken with Ubuntu noble linter image #1955

Open
ddelnano opened this issue Jun 24, 2024 · 0 comments
Open

Python/mypy linting broken with Ubuntu noble linter image #1955

ddelnano opened this issue Jun 24, 2024 · 0 comments
Labels
kind/bug Something isn't working

Comments

@ddelnano
Copy link
Member

Since the migration to Ubuntu noble for the linter and dev docker images, mypy linting is no longer working. The flake8 integration used has been deprecated since 2020 and it seems that mypy is stuck with using an older interpreter. This would be a good candidate to migrate to the next linting solution (#1896).

Steps to reproduce:

  1. Introduce change to a python file
  2. Run arc lint
  3. See the following error
>>> Lint for tools/licenses/checker.py:
   Error  (T499) flake8 T499
    usage: mypy [-h] [-v] [-V] [more options; see below]
    >>>        1 #!/usr/bin/env python3
                 ^
               2 
               3 # Copyright 2018- The Pixie Authors.
               4 #
   Error  (T499) flake8 T499
    [-m MODULE] [-p PACKAGE] [-c PROGRAM_TEXT] [files ...]
               1 #!/usr/bin/env python3
    >>>        2 
                 ^
               3 # Copyright 2018- The Pixie Authors.
               4 #
               5 # Licensed under the Apache License, Version 2.0 (the "License");
   Error  (T499) flake8 T499
    mypy: error: argument --python-version: Python 3.6 is not supported (must
    be 3.8 or higher)
               1 #!/usr/bin/env python3
               2 
    >>>        3 # Copyright 2018- The Pixie Authors.
                 ^
               4 #
               5 # Licensed under the Apache License, Version 2.0 (the "License");
               6 # you may not use this file except in compliance with the License.
@ddelnano ddelnano added the kind/bug Something isn't working label Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant