Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Add limited support for JS bricks #2034

Closed
twschiller opened this issue Dec 2, 2021 · 2 comments
Closed

RFC: Add limited support for JS bricks #2034

twschiller opened this issue Dec 2, 2021 · 2 comments
Labels
brick enhancement New feature or request

Comments

@twschiller
Copy link
Contributor

twschiller commented Dec 2, 2021

Context

Related Browser Vendor Issues:

Related w3c Issues:

Related PixieBrix Issues:

@twschiller twschiller added enhancement New feature or request brick labels Dec 2, 2021
@fregante
Copy link
Contributor

fregante commented Dec 2, 2021

The scripting API is mostly equivalent to the current Tabs API for executing scripts, it still does not allow remote scripts nor userscripts yet. I think it will be a bit difficult to pass review should it ever get flagged.

My guess is that if they were to add support for userscripts, they would have to be provided by the user explicitly rather than loaded from a server wrapped in additional logic (i.e. bricks and blueprints)

I have never submitted an extension with the “remote code” capability, but as far as I know you have to specify that the extension does that in the CWS admin area. That alone will likely trigger a manual review, even in MV2

@twschiller
Copy link
Contributor Author

twschiller commented Dec 3, 2021

My guess is that if they were to add support for userscripts, they would have to be provided by the user explicitly rather than loaded from a server wrapped in additional logic (i.e. bricks and blueprints)

I think that's probably right. The grey area is in how much "help" the user gets to provide the logic

So far we have not had to indicate we include remote code and have never been flagged for it (with 1yr+ of submitting to CWS). Not sure if the MV3 review process will flag it. We'll probably need to submit an MV3 version at some point to find out. There are still some MV3 gaps I've been waiting for them to address though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brick enhancement New feature or request
Development

No branches or pull requests

2 participants