Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please get modified platform-api into heroku/platform-api #55

Closed
david-a-wheeler opened this issue Apr 11, 2017 · 2 comments
Closed

Please get modified platform-api into heroku/platform-api #55

david-a-wheeler opened this issue Apr 11, 2017 · 2 comments
Labels

Comments

@david-a-wheeler
Copy link

The current directions require installation of a forked version of platform-api. I think it'd be much better/safer if that were merged into the upstream heroku/platform-api.

Could you submit a pull request to heroku/platform-api to get the necessary support into that? Here is a related issue.

@jalada jalada added the wontfix label Apr 12, 2017
@jalada
Copy link
Collaborator

jalada commented Apr 12, 2017

Hi @david-a-wheeler. Completely agree, I'm not happy with using a fork of the gem.

However there are already multiple issues and PRs open requesting that they update the schema:

It's also been discussed within letsencrypt-rails-heroku:

@jalada jalada closed this as completed Apr 12, 2017
@jalada
Copy link
Collaborator

jalada commented Apr 12, 2019

Two years to the day! Letsencrypt-rails-heroku is now using the officially-published version of platform-api as of version 1.2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants