Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] HTMLAudioInstance.ts #264

Closed
twobear opened this issue Mar 12, 2024 · 2 comments · Fixed by #268
Closed

[bug] HTMLAudioInstance.ts #264

twobear opened this issue Mar 12, 2024 · 2 comments · Fixed by #268

Comments

@twobear
Copy link

twobear commented Mar 12, 2024

Bug Description:

There is a potential writing error in sound/src/htmlaudio/HTMLAudioInstance.ts on line 341.

The code snippet this.emit('progress', start, this._duration); should have 'start' modified to 'start/this._duration'.

Steps to Reproduce:

Navigate to the sound/src/htmlaudio/HTMLAudioInstance.ts file.
Go to line 341.
Note the mentioned code snippet.
Expected Behavior:

Modify the code to change this.emit('progress', start, this._duration); with start/this._duration to ensure correct behavior.

Thank you for bringing this to attention, looking forward to the resolution of the issue!
@FerLuisxd
Copy link

Same here.

@bigtimebuddy bigtimebuddy mentioned this issue Jul 26, 2024
Merged
@bigtimebuddy
Copy link
Member

Released in v6.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Incorrect parameter with progress event on html instance pixijs/sound
3 participants
@bigtimebuddy @twobear @FerLuisxd