Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support node 14+ #135

Merged
merged 1 commit into from
Jun 20, 2022
Merged

support node 14+ #135

merged 1 commit into from
Jun 20, 2022

Conversation

bakkot
Copy link
Collaborator

@bakkot bakkot commented Jun 15, 2022

Fixes #131. The only change required was using node 14's primordials.js (which is more than adequate for this package). While I was at it I've included the license for that file, since it's a direct copy.

shadowspawn
shadowspawn approved these changes Jun 15, 2022
View reviewed changes
Copy link
Collaborator

@shadowspawn shadowspawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I manually checked tests ran with oldest and newest versions of Node 14, 16, 18.

@bakkot bakkot requested a review from bcoe June 15, 2022 15:16
@bcoe bcoe merged commit 6a1c5a6 into main Jun 20, 2022
@bcoe bcoe deleted the node-14 branch June 20, 2022 18:46
@bcoe
Copy link
Collaborator

bcoe commented Jun 20, 2022

@bakkot thanks for doing this 👍

@github-actions github-actions bot mentioned this pull request Jun 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcoe bcoe bcoe approved these changes

@shadowspawn shadowspawn shadowspawn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

What's the minimum required Node.js version for this package?
3 participants
@bakkot @bcoe @shadowspawn