-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: expand scenarios covered by default arguments for environments #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- detect REPL - detect bundled Electron app - otherwise process.argv.slice(2)
Just spotted |
|
Added
|
bcoe
reviewed
Dec 4, 2021
bcoe
approved these changes
Dec 4, 2021
Added tests, refactored code to be an explicit placeholder for |
This was referenced Dec 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We are proposing to determine appropriate default arguments for
node --eval
, Electron, and ES6.Using
require.main
to determine--eval
(or REPL) gives false positive for ES6 main program.Related: #5 #18
Solution
Implement a placeholder for
process.mainArgs
that covers the scenarios that have been raised.node --eval
directly by checking options passed to node (-e
,--eval
)node --print
directly by checking options passed to node (-p
,--print
)process.argv.slice(2)
Related PRs for Electron argument processing:
And for historical interest, the addition of
defaultApp
in Electron to work-around the variant behaviour:Example