Do not strip excess leading dashes on long option names #21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
All leading dashes on options are being stripped. This was to allow
-foo
treated the same as--foo
for some circumstances, but that approach is being reconsidered to fully support short option flags and have simple consistent behaviour.Note: the preflight checks in current limited code mean this is only affecting two or more dashes.
See #7 and #2
Solution
Only strip the two leading dashes of an option with two or more leading dashes.
---foo
is parsed as an option named-foo
.(I followed the lint rules for the test file, rather than the local code style. I did not modify the rest of the file to pass the linter to keep this PR focused.)