Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: always store value for a=b #43

Merged
merged 5 commits into from
Feb 4, 2022
Merged

Conversation

shadowspawn
Copy link
Collaborator

@shadowspawn shadowspawn commented Jan 23, 2022

This actually has two fixes in just two statements. They overlap, so not separate PR. :-)

The big change is always store the value for --foo=value, even for zero-config. See #24 for discussion to support this. This approach:

  • reflects user intent
  • preserves information for author curation
  • does not introduce a new pattern in the shape of the result

Closes #24.

The small fix is --foo=b=c stores the value b=c (previously was ignoring text from the second equals onwards).

(Code previously proposed and reviewed in #26, so will look familiar logic to some.)

@bcoe

This comment has been minimized.

@shadowspawn
Copy link
Collaborator Author

Thanks reviewers. I will merge this weekend if nothing else comes up.

@bcoe bcoe merged commit a85e8dc into pkgjs:main Feb 4, 2022
@shadowspawn shadowspawn deleted the feature/fix-equals branch February 5, 2022 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Behaviour for zero config --foo=a ?
5 participants