From f6104f6e7236666358a905fc593ba6a154045639 Mon Sep 17 00:00:00 2001
From: Pavel Kirilin <kirilin.pav@gmail.com>
Date: Fri, 29 Mar 2024 21:58:27 +0300
Subject: [PATCH] Use separate subheader for PageDetailHeader

---
 .../features/pages/ui/PageDetailHeader.tsx    | 38 ++++----------
 src/frontend/src/pages/ui/PageDetailPage.tsx  |  3 +-
 src/frontend/src/shared/constants.ts          |  3 +-
 src/frontend/src/shared/ui/AppShell.tsx       | 50 ++++++++++++++++---
 .../src/widgets/layout/ui/PrivateLayout.tsx   | 24 +++++----
 .../src/widgets/navbar/ui/MobileMenu.tsx      |  9 +++-
 .../src/widgets/navbar/ui/NavigationBar.tsx   | 11 ++--
 7 files changed, 81 insertions(+), 57 deletions(-)

diff --git a/src/frontend/src/features/pages/ui/PageDetailHeader.tsx b/src/frontend/src/features/pages/ui/PageDetailHeader.tsx
index 2435f7210..410f40aaf 100644
--- a/src/frontend/src/features/pages/ui/PageDetailHeader.tsx
+++ b/src/frontend/src/features/pages/ui/PageDetailHeader.tsx
@@ -1,16 +1,11 @@
 import ArrowBackIcon from '@mui/icons-material/ArrowBack';
 import {
-  AppBar,
-  Box,
-  Container,
   IconButton,
   Stack,
-  Toolbar,
   Tooltip,
   Typography,
   type TypographyProps,
   styled,
-  useScrollTrigger,
 } from '@mui/material';
 import { useMemo, type FC } from 'react';
 import { Link as RouterLink } from 'react-router-dom';
@@ -18,8 +13,6 @@ import { notesApi } from 'src/features/notes';
 import { formatDate } from 'src/utils';
 import { type Page } from '../models';
 
-const DIVIDER_VISIBLE_SCROLL_THRESHOLD = 16;
-
 interface Props {
   page: Page;
 }
@@ -35,26 +28,17 @@ export const PageDetailHeader: FC<Props> = ({ page }) => {
   const notes = useMemo(() => getNotesQuery.data ?? [], [getNotesQuery.data]);
   const totalCalories = useMemo(() => notes.reduce((sum, note) => sum + note.calories, 0), [notes]);
 
-  const pageScrolled = useScrollTrigger({
-    threshold: DIVIDER_VISIBLE_SCROLL_THRESHOLD,
-    disableHysteresis: true,
-  });
-
   return (
-    <AppBar color="inherit" position="static" elevation={pageScrolled ? 1 : 0} component="nav">
-      <Container>
-        <Toolbar disableGutters component={Box} display="flex" alignItems="center" gap={2}>
-          <Tooltip title="Back to pages list">
-            <IconButton edge="start" component={RouterLink} to="/pages">
-              <ArrowBackIcon />
-            </IconButton>
-          </Tooltip>
-          <Stack direction="row" spacing={2} justifyContent="space-between" width="100%">
-            <TextStyled component="h1">{formatDate(new Date(page.date))}</TextStyled>
-            <TextStyled component="span">{totalCalories} kcal</TextStyled>
-          </Stack>
-        </Toolbar>
-      </Container>
-    </AppBar>
+    <>
+      <Tooltip title="Back to pages list">
+        <IconButton component={RouterLink} to="/pages" sx={{ marginRight: 1 }}>
+          <ArrowBackIcon />
+        </IconButton>
+      </Tooltip>
+      <Stack direction="row" spacing={2} justifyContent="space-between" width="100%">
+        <TextStyled component="h1">{formatDate(new Date(page.date))}</TextStyled>
+        <TextStyled component="span">{totalCalories} kcal</TextStyled>
+      </Stack>
+    </>
   );
 };
diff --git a/src/frontend/src/pages/ui/PageDetailPage.tsx b/src/frontend/src/pages/ui/PageDetailPage.tsx
index f122a85f2..37f661ad3 100644
--- a/src/frontend/src/pages/ui/PageDetailPage.tsx
+++ b/src/frontend/src/pages/ui/PageDetailPage.tsx
@@ -30,8 +30,7 @@ export const Component: FC = () => {
 
   return (
     <PrivateLayout
-      withAdditionalNavigation
-      header={
+      subheader={
         getPageByIdQuery.data && <PageDetailHeader page={getPageByIdQuery.data.currentPage} />
       }
     >
diff --git a/src/frontend/src/shared/constants.ts b/src/frontend/src/shared/constants.ts
index 8005c819e..b04abaabb 100644
--- a/src/frontend/src/shared/constants.ts
+++ b/src/frontend/src/shared/constants.ts
@@ -1,3 +1,4 @@
-export const APP_BAR_HEIGHT = 66;
+export const APP_BAR_HEIGHT_XS = 56;
+export const APP_BAR_HEIGHT_SM = 64;
 
 export const SIDEBAR_DRAWER_WIDTH = 256;
diff --git a/src/frontend/src/shared/ui/AppShell.tsx b/src/frontend/src/shared/ui/AppShell.tsx
index d38413bea..26a1c49e6 100644
--- a/src/frontend/src/shared/ui/AppShell.tsx
+++ b/src/frontend/src/shared/ui/AppShell.tsx
@@ -1,41 +1,79 @@
 import { AppBar, Box, Container, LinearProgress, Toolbar } from '@mui/material';
 import { type PropsWithChildren, type FC, type ReactElement } from 'react';
-import { APP_BAR_HEIGHT, SIDEBAR_DRAWER_WIDTH } from '../constants';
+import { APP_BAR_HEIGHT_SM, APP_BAR_HEIGHT_XS, SIDEBAR_DRAWER_WIDTH } from '../constants';
 
 interface Props extends PropsWithChildren {
   withNavigationProgress: boolean;
-  withAdditionalNavigation?: boolean;
   withSidebar?: boolean;
   header?: ReactElement;
+  subheader?: ReactElement;
+  subheaderElevation?: number;
 }
 
 export const AppShell: FC<Props> = ({
   children,
   withNavigationProgress,
-  withAdditionalNavigation,
   withSidebar,
   header,
+  subheader,
+  subheaderElevation,
 }) => (
   <>
     {header && (
-      <AppBar variant="outlined">
+      <AppBar>
         <Box component={Toolbar} disableGutters px={{ xs: 1, sm: 2, md: 1 }}>
           {header}
         </Box>
       </AppBar>
     )}
+    {subheader && (
+      <AppBar
+        position="sticky"
+        elevation={subheaderElevation}
+        component={Box}
+        color="inherit"
+        ml={{
+          xs: 0,
+          md: withSidebar ? `${SIDEBAR_DRAWER_WIDTH}px` : 0,
+        }}
+        width={{
+          xs: '100%',
+          md: withSidebar ? `calc(100% - ${SIDEBAR_DRAWER_WIDTH}px)` : '100%',
+        }}
+        sx={{
+          top: {
+            xs: APP_BAR_HEIGHT_XS,
+            sm: APP_BAR_HEIGHT_SM,
+          },
+        }}
+      >
+        <Container disableGutters>
+          <Box
+            component={Toolbar}
+            disableGutters
+            pl={{ xs: 1, sm: 2, md: 1 }}
+            pr={{ xs: 2, sm: 3 }}
+          >
+            {subheader}
+          </Box>
+        </Container>
+      </AppBar>
+    )}
     {withNavigationProgress && (
       <LinearProgress
         sx={{
           position: 'absolute',
-          top: APP_BAR_HEIGHT,
+          top: {
+            xs: APP_BAR_HEIGHT_XS,
+            sm: APP_BAR_HEIGHT_SM,
+          },
           width: '100%',
         }}
       />
     )}
     <Box
       component="main"
-      pt={withAdditionalNavigation ? 0 : 3}
+      pt={subheader ? 0 : 3}
       pb={3}
       ml={{
         xs: 0,
diff --git a/src/frontend/src/widgets/layout/ui/PrivateLayout.tsx b/src/frontend/src/widgets/layout/ui/PrivateLayout.tsx
index aa1bde18e..a9bc744e4 100644
--- a/src/frontend/src/widgets/layout/ui/PrivateLayout.tsx
+++ b/src/frontend/src/widgets/layout/ui/PrivateLayout.tsx
@@ -1,34 +1,36 @@
-import { type Theme, useMediaQuery } from '@mui/material';
+import { type Theme, useMediaQuery, useScrollTrigger } from '@mui/material';
 import { type PropsWithChildren, type FC, type ReactElement } from 'react';
 import { useAuthStatusCheckEffect } from '@/features/auth';
+import { APP_BAR_HEIGHT_SM, APP_BAR_HEIGHT_XS } from '@/shared/constants';
 import { useToggle } from '@/shared/hooks';
 import { AppShell } from '@/shared/ui';
 import { NavigationBar } from '@/widgets/navbar';
 import { useNavigationProgress } from '../lib';
 
 interface Props extends PropsWithChildren {
-  header?: ReactElement;
-  withAdditionalNavigation?: boolean;
+  subheader?: ReactElement;
 }
 
-export const PrivateLayout: FC<Props> = ({ children, header, withAdditionalNavigation }) => {
+export const PrivateLayout: FC<Props> = ({ children, subheader }) => {
   const navigationProgressVisible = useNavigationProgress();
+  const sm = useMediaQuery<Theme>(theme => theme.breakpoints.down('sm'));
   const isMobile = useMediaQuery<Theme>(theme => theme.breakpoints.down('md'));
   const [menuOpened, toggleMenu] = useToggle(!isMobile);
 
+  const pageScrolled = useScrollTrigger({
+    threshold: (sm ? APP_BAR_HEIGHT_SM : APP_BAR_HEIGHT_XS) / 2,
+    disableHysteresis: true,
+  });
+
   useAuthStatusCheckEffect();
 
   return (
     <AppShell
       withNavigationProgress={navigationProgressVisible}
-      withAdditionalNavigation={withAdditionalNavigation}
       withSidebar={menuOpened}
-      header={
-        <>
-          <NavigationBar menuOpened={menuOpened} toggleMenu={toggleMenu} />
-          {header}
-        </>
-      }
+      header={<NavigationBar menuOpened={menuOpened} toggleMenu={toggleMenu} />}
+      subheader={subheader}
+      subheaderElevation={pageScrolled ? 1 : 0}
     >
       {children}
     </AppShell>
diff --git a/src/frontend/src/widgets/navbar/ui/MobileMenu.tsx b/src/frontend/src/widgets/navbar/ui/MobileMenu.tsx
index 0a95324ba..e3ae79508 100644
--- a/src/frontend/src/widgets/navbar/ui/MobileMenu.tsx
+++ b/src/frontend/src/widgets/navbar/ui/MobileMenu.tsx
@@ -13,7 +13,7 @@ import {
 } from '@mui/material';
 import { type FC, useState } from 'react';
 import { Link } from 'react-router-dom';
-import { APP_BAR_HEIGHT } from '@/shared/constants';
+import { APP_BAR_HEIGHT_SM } from '@/shared/constants';
 import { APP_NAME, NAV_LINKS } from '../lib';
 
 export const MobileMenu: FC = () => {
@@ -51,7 +51,12 @@ export const MobileMenu: FC = () => {
           <IconButton size="large" aria-label="Close menu" onClick={handleMenuToggle}>
             <CloseIcon />
           </IconButton>
-          <Box display="flex" justifyContent="center" alignItems="center" height={APP_BAR_HEIGHT}>
+          <Box
+            display="flex"
+            justifyContent="center"
+            alignItems="center"
+            height={APP_BAR_HEIGHT_SM}
+          >
             <Typography
               sx={theme => ({
                 fontSize: theme.typography.h1.fontSize,
diff --git a/src/frontend/src/widgets/navbar/ui/NavigationBar.tsx b/src/frontend/src/widgets/navbar/ui/NavigationBar.tsx
index 0ea903a65..79f5ba76c 100644
--- a/src/frontend/src/widgets/navbar/ui/NavigationBar.tsx
+++ b/src/frontend/src/widgets/navbar/ui/NavigationBar.tsx
@@ -14,7 +14,7 @@ import {
 } from '@mui/material';
 import { type FC } from 'react';
 import { Form } from 'react-router-dom';
-import { APP_BAR_HEIGHT, SIDEBAR_DRAWER_WIDTH } from '@/shared/constants';
+import { APP_BAR_HEIGHT_SM, SIDEBAR_DRAWER_WIDTH } from '@/shared/constants';
 import { APP_NAME } from '../lib';
 import { MenuList } from './MenuList';
 
@@ -59,18 +59,13 @@ export const NavigationBar: FC<Props> = ({ menuOpened, toggleMenu }) => {
         ModalProps={{ keepMounted: isMobile }}
         PaperProps={{
           sx: {
-            marginTop: { xs: 0, md: `${APP_BAR_HEIGHT}px` },
+            marginTop: { xs: 0, md: `${APP_BAR_HEIGHT_SM}px` },
             width: { xs: '75%', md: `${SIDEBAR_DRAWER_WIDTH}px` },
           },
           component: 'nav',
         }}
       >
-        <Box
-          component={AppBar}
-          variant="outlined"
-          position="static"
-          display={{ xs: 'block', md: 'none' }}
-        >
+        <Box component={AppBar} position="static" display={{ xs: 'block', md: 'none' }}>
           <Box px={1} component={Toolbar} disableGutters>
             <Box display="flex" gap={3} alignItems="center">
               <IconButton color="inherit" aria-label="Close menu" onClick={toggleMenu}>