Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification NOTIFICATION_TYPE_FORMAT_NEEDS_APPROVED_SUBMISSION is not updated&displayed #10636

Open
jardakotesovec opened this issue Nov 26, 2024 · 0 comments
Assignees
Labels
Bug:1:Low A bug that does not have a severe consequence or affects a small number of users.
Milestone

Comments

@jardakotesovec
Copy link
Contributor

Describe the bug
While working on reviewing what notifications we display in current workflow, I run into one OMP notification, which works in 3.3, but not in 3.4/3.5.

Image

To Reproduce
Steps to reproduce the behavior:

  1. Go to Submission which is in Production stage but not yet published
  2. See notification in 3.3 but not in 3.4/3.5

Investigation
I think that this notification is created in PKPApproveSubmissionNotificationManager.inc.php, when this notification update is triggered - https://github.com/pkp/pkp-lib/blob/stable-3_3_0/classes/submission/form/PKPSubmissionSubmitStep4Form.inc.php#L161

I suspect this was not carried over to 3.4.0.

What application are you using?
OMP 3.4/3.5

@jardakotesovec jardakotesovec added the Bug:1:Low A bug that does not have a severe consequence or affects a small number of users. label Nov 26, 2024
@jardakotesovec jardakotesovec added this to the 3.4.0-8 milestone Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug:1:Low A bug that does not have a severe consequence or affects a small number of users.
Projects
None yet
Development

No branches or pull requests

2 participants