Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

silently ignore onion addresses in peers.json #217

Open
cjdelisle opened this issue Nov 18, 2020 · 2 comments
Open

silently ignore onion addresses in peers.json #217

cjdelisle opened this issue Nov 18, 2020 · 2 comments

Comments

@cjdelisle
Copy link
Member

Should be silently skipped:

1605707594 [ERR] AMGR addrmanager.go:433: Failed to parse file /Users/user/Library/Application Support/Pktwallet/pkt/peers.json: 1.1.1-354914b8 failed to deserialize netaddress dvxyatqge3qfhd5p.onion:6476
4: 1.1.1-354914b8 lookup dvxyatqge3qfhd5p.onion: no such host                                                                                                                                               
                                                                                                                                                                                                            
  btcutil/er/er.go:359 +0x16d     btcutil/er.E()                                                                                                                                                            
  neutrino/neutrino.go:661 +0x6f          neutrino.NewChainService.func2()                                                                                                                                  
  addrmgr/addrmanager.go:733 +0xb7        addrmgr.(*AddrManager).HostToNetAddress()                                                                                                                         
  addrmgr/addrmanager.go:567 +0x10d       addrmgr.(*AddrManager).DeserializeNetAddress()
  addrmgr/addrmanager.go:485 +0x389       addrmgr.(*AddrManager).deserializePeers()                                                                                                                           addrmgr/addrmanager.go:431 +0x7d        addrmgr.(*AddrManager).loadPeers()
  addrmgr/addrmanager.go:581 +0xad        addrmgr.(*AddrManager).Start()                                                                                                                                    
  neutrino/neutrino.go:1511 +0x4b         neutrino.(*ChainService).Start()                                                                                                                                  
  pktwallet/chain/neutrino.go:45 +0x2e    pktwallet/chain.(*NeutrinoClient).Start()
  pktwallet/pktwallet.go:213 +0x96a       main.rpcClientConnectLoop()
  pktwallet/pktwallet.go:109 +0x7b2       created by main.walletMain


  btcutil/er/er.go:343 +0x8d      btcutil/er.Errorf()
  addrmgr/addrmanager.go:487 +0x704       addrmgr.(*AddrManager).deserializePeers()
  addrmgr/addrmanager.go:431 +0x7d        addrmgr.(*AddrManager).loadPeers()
  addrmgr/addrmanager.go:581 +0xad        addrmgr.(*AddrManager).Start()
  neutrino/neutrino.go:1511 +0x4b         neutrino.(*ChainService).Start()
  pktwallet/chain/neutrino.go:45 +0x2e    pktwallet/chain.(*NeutrinoClient).Start()
  pktwallet/pktwallet.go:213 +0x96a       main.rpcClientConnectLoop()
  pktwallet/pktwallet.go:109 +0x7b2       created by main.walletMain

@johnsonjh

@johnsonjh
Copy link

Will do

@johnsonjh
Copy link

johnsonjh commented Nov 19, 2020

@cjdelisle #223 should do the trick

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants