Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/weekdaycharging #1340

Merged
merged 10 commits into from
Aug 8, 2024
Merged

feat/weekdaycharging #1340

merged 10 commits into from
Aug 8, 2024

Conversation

pkuehnel
Copy link
Owner

No description provided.

@pkuehnel
Copy link
Owner Author

@b1ggi Unit tests seem to fail. If you resolve that, I will create a release to test the feature.

@pkuehnel pkuehnel force-pushed the feat/addOptionToChargeOnlyOnWeekDays branch from 953d9d9 to f76349e Compare June 29, 2024 13:20
@b1ggi
Copy link

b1ggi commented Jun 30, 2024

Fix for failed tests in PR #1342

@pkuehnel
Copy link
Owner Author

@b1ggi You can now test everything using :weekdaycharging as tag instead of :latest.

@b1ggi b1ggi mentioned this pull request Jun 30, 2024
@pkuehnel pkuehnel linked an issue Jun 30, 2024 that may be closed by this pull request
@b1ggi
Copy link

b1ggi commented Jul 2, 2024

Found a bug
image
The new Box only appears after pressing CTRL+F5
image

will fix on weekend

@pkuehnel
Copy link
Owner Author

pkuehnel commented Jul 2, 2024

@b1ggi I think that is not a weekdaycharging specific bug, but thanks in advance for resolving it.

@pkuehnel pkuehnel force-pushed the feat/addOptionToChargeOnlyOnWeekDays branch from 2c8064b to 6df0795 Compare July 4, 2024 16:06
@pkuehnel
Copy link
Owner Author

pkuehnel commented Jul 4, 2024

@b1ggi due to various overlapping changes I needed to rebase the branch onto develop. Please use the latest version for your fixes.

@pkuehnel
Copy link
Owner Author

pkuehnel commented Jul 6, 2024

@b1ggi Just noticed that due to my rebase all commits are counted for me so you need to make another commit to be mentioned as a contributor -.-

Base automatically changed from develop to master July 7, 2024 17:21
@pkuehnel pkuehnel force-pushed the feat/addOptionToChargeOnlyOnWeekDays branch from 6df0795 to 1d8df2e Compare July 7, 2024 17:22
@pkuehnel
Copy link
Owner Author

pkuehnel commented Jul 7, 2024

@b1ggi needed to reabase again, sorry. I just released again without that feature, can you tell me when you are ready and everything is tested?

@b1ggi
Copy link

b1ggi commented Aug 8, 2024

@pkuehnel i tested the feature now for 1 month (i recently also installed a 32kwh diy-battery) and it works like expected, and im very happy with the feature, it really helps to optimize charging for a normal Mo-Fr week.

It would be nice if it would be possible to select specific Days to charge, but if there is no demand, i think were good.

I cannot reproduce the bug i mentioned above, i think it was a browser cache problem after updating.

@pkuehnel pkuehnel changed the base branch from master to develop August 8, 2024 10:01
@pkuehnel pkuehnel force-pushed the feat/addOptionToChargeOnlyOnWeekDays branch from 31cf0b7 to 1d8df2e Compare August 8, 2024 10:05
@pkuehnel pkuehnel force-pushed the feat/addOptionToChargeOnlyOnWeekDays branch from 1d8df2e to 1dc9bec Compare August 8, 2024 10:06
@pkuehnel
Copy link
Owner Author

pkuehnel commented Aug 8, 2024

Thanks for your effort. As I needed to fix a few merge conflicts you won't be displayed as contributor. If you want to be displayed (And to be honest I want the list of contributors to be complete), create a fork from this branch and remove the first line of this file.

Because of rebase previous commits omitted Contributor State
@b1ggi
Copy link

b1ggi commented Aug 8, 2024

#1417

Like this?

@pkuehnel pkuehnel merged commit 16c5180 into develop Aug 8, 2024
6 checks passed
@pkuehnel pkuehnel deleted the feat/addOptionToChargeOnlyOnWeekDays branch August 8, 2024 11:35
@pkuehnel
Copy link
Owner Author

pkuehnel commented Aug 8, 2024

@b1ggi You can now update to :edge. This is the latest alpha release, including your weekday charging feature. When the next version is released, your feature will be included. Thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Min Soc based on weekdays
2 participants