-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/weekdaycharging #1340
feat/weekdaycharging #1340
Conversation
@b1ggi Unit tests seem to fail. If you resolve that, I will create a release to test the feature. |
953d9d9
to
f76349e
Compare
Fix for failed tests in PR #1342 |
@b1ggi You can now test everything using |
@b1ggi I think that is not a weekdaycharging specific bug, but thanks in advance for resolving it. |
2c8064b
to
6df0795
Compare
@b1ggi due to various overlapping changes I needed to rebase the branch onto develop. Please use the latest version for your fixes. |
@b1ggi Just noticed that due to my rebase all commits are counted for me so you need to make another commit to be mentioned as a contributor -.- |
6df0795
to
1d8df2e
Compare
@b1ggi needed to reabase again, sorry. I just released again without that feature, can you tell me when you are ready and everything is tested? |
@pkuehnel i tested the feature now for 1 month (i recently also installed a 32kwh diy-battery) and it works like expected, and im very happy with the feature, it really helps to optimize charging for a normal Mo-Fr week. It would be nice if it would be possible to select specific Days to charge, but if there is no demand, i think were good. I cannot reproduce the bug i mentioned above, i think it was a browser cache problem after updating. |
31cf0b7
to
1d8df2e
Compare
…t Price + PV" only on weekdays
…t Price + PV" only on weekdays
1d8df2e
to
1dc9bec
Compare
This reverts commit 1dc9bec.
Thanks for your effort. As I needed to fix a few merge conflicts you won't be displayed as contributor. If you want to be displayed (And to be honest I want the list of contributors to be complete), create a fork from this branch and remove the first line of this file. |
Because of rebase previous commits omitted Contributor State
Like this? |
Update Car.cs - Fix Github Contributer
@b1ggi You can now update to |
No description provided.