From 56e54ac01556725aa66b0e4ad963478a7387ec41 Mon Sep 17 00:00:00 2001
From: Arthur Bit-Monnot <abitmonnot@laas.fr>
Date: Thu, 21 Nov 2024 17:02:30 +0100
Subject: [PATCH] ci: upgrade artifacct-handling actions

---
 .github/workflows/aries.yml | 45 ++++++++++++++++++++-----------------
 1 file changed, 24 insertions(+), 21 deletions(-)

diff --git a/.github/workflows/aries.yml b/.github/workflows/aries.yml
index 249b2cfb..30f86dbd 100644
--- a/.github/workflows/aries.yml
+++ b/.github/workflows/aries.yml
@@ -23,7 +23,7 @@ jobs:
       - uses: actions/checkout@v3
         with:
           fetch-depth: 0
-      - uses: dtolnay/rust-toolchain@1.80.1  # fixed version to avoid failures on rust version releases
+      - uses: dtolnay/rust-toolchain@1.80.1 # fixed version to avoid failures on rust version releases
         with:
           components: clippy, rustfmt
       - run: cargo fmt --all -- --check
@@ -77,7 +77,6 @@ jobs:
           cd ../../..
           git diff --exit-code
 
-
   unified-planning-integration:
     name: UP Integration Tests
     runs-on: ubuntu-22.04
@@ -85,7 +84,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: dtolnay/rust-toolchain@stable
       - name: Submodules initialization
-        run: git submodule update --init  # get our own copy of unified-planing repos
+        run: git submodule update --init # get our own copy of unified-planing repos
       - name: Install python dependencies
         run: python3 -m pip install -r planning/unified/requirements.txt "numpy<2"
       - name: Install just
@@ -95,7 +94,6 @@ jobs:
       - name: Validator tests
         run: ./just ci-up-val
 
-
   ipc-tests:
     name: IPC Tests
     runs-on: ubuntu-22.04
@@ -103,31 +101,36 @@ jobs:
       - uses: actions/checkout@v3
       - uses: dtolnay/rust-toolchain@stable
       - name: Submodules initialization
-        run: git submodule update --init  # get our own copy of unified-planing repos
+        run: git submodule update --init # get our own copy of unified-planing repos
       - name: Install python dependencies
         run: python3 -m pip install -r planning/unified/requirements.txt "numpy<2"
       - name: Install just
         run: curl --proto '=https' --tlsv1.2 -sSf https://just.systems/install.sh | bash -s -- --to .
       - name: Resolution
         run: ./just ci-ipc
-  
 
   tests: # Meta-job that only requires all test-jobs to pass
-    needs: [ lints, unit-tests, integration-tests, unified-planning-api, unified-planning-integration, ipc-tests ]
+    needs:
+      [
+        lints,
+        unit-tests,
+        integration-tests,
+        unified-planning-api,
+        unified-planning-integration,
+        ipc-tests,
+      ]
     runs-on: ubuntu-latest
     steps:
       - run: true
 
-
-
   # ================ Building & Releasing binaries.
   # Only active on the master branch and when the previous validation steps passed
 
   build: # Build release binaries for all architecture and save them as artifacts
     strategy:
       matrix:
-        os: [ ubuntu-latest, macos-latest, windows-latest ]
-        target: [ amd64, arm64 ]
+        os: [ubuntu-latest, macos-latest, windows-latest]
+        target: [amd64, arm64]
         exclude:
           - os: ubuntu-latest
             target: arm64 # linux-arm64 build has linker issues, done in a distinct job
@@ -174,7 +177,7 @@ jobs:
           mkdir -p bins/
           cp target/${{ env.TARGET }}/release/up-server bins/${{ env.BINARY }}
       - name: Upload artifact
-        uses: actions/upload-artifact@v2
+        uses: actions/upload-artifact@v4
         with:
           name: ${{ env.BINARY }}
           path: bins/${{ env.BINARY }}
@@ -229,7 +232,7 @@ jobs:
 
   package-python:
     name: Python Package (up_aries)
-    needs: [ build ]
+    needs: [build]
     runs-on: ubuntu-latest
     if: (github.ref == 'refs/heads/master') || startsWith(github.ref, 'refs/tags/v')
     steps:
@@ -242,10 +245,10 @@ jobs:
           git describe --tags --match v[0-9]*
       - uses: actions/setup-python@v4
         with:
-          python-version: '3.8'
+          python-version: "3.8"
       - name: Install build tools
         run: pip install build
-      - uses: actions/download-artifact@v3
+      - uses: actions/download-artifact@v4
         with:
           path: planning/unified/plugin/artifacts
       - name: Unpack artifacts
@@ -258,7 +261,7 @@ jobs:
           ls -lR
           python -m build --sdist
           cp dist/up_aries-*.tar.gz up_aries.tar.gz
-      - uses: actions/upload-artifact@v3
+      - uses: actions/upload-artifact@v4
         with:
           name: up_aries.tar.gz
           path: planning/unified/plugin/up_aries.tar.gz
@@ -268,10 +271,10 @@ jobs:
     name: Pre Release
     runs-on: ubuntu-latest
     if: github.ref == 'refs/heads/master'
-    needs: [ tests, build, package-python ]
+    needs: [tests, build, package-python]
     steps:
       - name: Download artifact
-        uses: actions/download-artifact@v2
+        uses: actions/download-artifact@v4
 
       - name: Display artifacts
         run: ls -R
@@ -294,13 +297,13 @@ jobs:
     name: Release
     runs-on: ubuntu-latest
     if: startsWith(github.ref, 'refs/tags/v')
-    needs: [ tests, build, package-python ]
+    needs: [tests, build, package-python]
     steps:
       - name: Download artifact
-        uses: actions/download-artifact@v2
+        uses: actions/download-artifact@v4
 
       - name: Download TAR artifact for python package
-        uses: actions/download-artifact@v2
+        uses: actions/download-artifact@v4
         with:
           name: up_aries.tar.gz
           path: dist/