[Crash] when tapping on a repost

[mplorentz]

Describe the bug

A crash in Router.swift:67 when tapping on a repost.

To Reproduce

None yet

Screenshots or Video

If applicable, add screenshots or video to help explain your problem.

Technical info

• OS: iOS
• App Version: 0.2.3 (501 and 504)
• Environment: Staging

Additional context

Slack report one (with logs)
testflight crash log one
Slack report two (with logs)
testflight crash log two
Sentry issue

The crash is on the line fatalError("Tried to push a note with no identifier; that's not going to work."). Probably this should just be an assertion failure? But we still need to fix whatever code is creating a note with no identifier.

It's weird that the crashes reported in slack and testflight don't match up with the ones in Sentry.

[bryanmontz]

This should definitely be assertionFailure(_:) instead, so that it only crashes in dev and not production.

[pelumy]

Thanks for the tip @bryanmontz.

[mplorentz]

I just saw this crash when I tapped on the note quoted in note10x5wxcr37lzgrmqfwkq3dtzp5vwkl6qhre27736vuncre5prjerq9vpdp0. The quoted note hadn't finished loading when I tapped it, it was still spinning.

The logs showed that the pushed note had no author, identifier, or replaceableIdentifier.

I relaunched the app to see if I could reproduce but I couldn't. Maybe if I deleted the app I could but I don't have time for that right now.