Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete button on feedback page not working #10

Open
dbuese opened this issue Jan 3, 2018 · 2 comments
Open

Delete button on feedback page not working #10

dbuese opened this issue Jan 3, 2018 · 2 comments

Comments

@dbuese
Copy link

dbuese commented Jan 3, 2018

Hi,

while viewing your course at Lynda.com, everything worked fine. Deleting feedback entries too.
During the process of restarting npm via console a message appeared that a new version is available. I then executed:
npm install -g npm
it installed:
npm -v
5.6.0

After upgrading npm, i noticed that deleting the feedback entries stopped working. As i am not aware of any other updates that mighthave occured on my system, i assume it is strongly related to the npm update.

I was able to fix this by changing app/public/js/feedback.js:
< if (e.target.className == 'glyphicon glyphicon-remove') {

 if (e.target.className == 'feedback-delete btn btn-xs btn-danger') {

< output += '

';

output += '       <div class="media-left"><button id="' + key + '" class="feedback-delete btn btn-xs btn-danger"><span class="glyphicon glyphicon-remove"></span></button></div>';

I currently have Mac OS High Sierra with Firefox 57.0.3 installed.

Kind regards,
Daniel

@dbuese
Copy link
Author

dbuese commented Jan 3, 2018

replace

if (e.target.className == 'glyphicon glyphicon-remove') {
with
if (e.target.className == 'feedback-delete btn btn-xs btn-danger') {

and replace

output += '       <div class="media-left"><button class="feedback-delete btn btn-xs btn-danger"><span class="glyphicon glyphicon-remove"></span></button></div>'; 

with

output += '       <div class="media-left"><button id="' + key + '" class="feedback-delete btn btn-xs btn-danger"><span class="glyphicon glyphicon-remove"></span></button></div>';

@dbuese
Copy link
Author

dbuese commented Jan 3, 2018

Please note that the delete feedback entry button works in Safari (Version 11.0.1 (11604.3.5.1.1)) without the mentioned changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant