Bump idf-component-manager to 1.5.2 #1321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, merged! |
jonathandreyer
pushed a commit
to jonathandreyer/platform-espressif32
that referenced
this pull request
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 1.4.0 of idf-component-manager introduces the "license"-tag which works the same as the library.json "license"-tag.
Several libraries have already started to use this and I just bumped into this with my Robusto library, and when helping Radiolib getting in there. (Edit: saw that arduino-esp32 also use it)
The problem is that libraries before this instead fails, and thus the Platformio build fails, and the recommendation to update to a newer version doesn't help as the old one is installed again in the venv anyway (which actually makes the recommendation sort of pointless and misleading)
I am seeing no issue with going with the latest version here, it is not new either and seems stable.
Temporary workaround:
An ugly one for those that needs this fix before nest platform-espressif-release, at least for *nix variants:
Do the suggested venv idf-component update (not the system one) using sudo, that way the platformio build fails reinstalling the "old" idf-component-manager, but still completes the build process.
sudo -H ~/.platformio/penv/.espidf-5.1.2/bin/python -m pip install --upgrade idf-component-managerNote that you will have to remove the .espidf-5.1.2 folder to make it reinstall later on