From b241daa8bce3040f881bbf7c941bc351befef5a6 Mon Sep 17 00:00:00 2001 From: Derek Wickern Date: Mon, 6 Jun 2022 15:28:39 -0700 Subject: [PATCH 1/3] Fix no-compare-relation-boolean error when passing <2 args --- lib/rules/no-compare-relation-boolean.js | 3 +++ tests/lib/rules/no-compare-relation-boolean.js | 5 ++++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/lib/rules/no-compare-relation-boolean.js b/lib/rules/no-compare-relation-boolean.js index 0e1c7eb3..046cdd46 100644 --- a/lib/rules/no-compare-relation-boolean.js +++ b/lib/rules/no-compare-relation-boolean.js @@ -86,6 +86,9 @@ module.exports = { function checkAssertArguments(callExprNode) { const args = [...callExprNode.arguments]; + if (args.length <= 2) { + return; + } const firstTwoArgsSorted = args.slice(0, 2).sort(sortLiteralFirst); diff --git a/tests/lib/rules/no-compare-relation-boolean.js b/tests/lib/rules/no-compare-relation-boolean.js index c0fb508c..e9c848b8 100644 --- a/tests/lib/rules/no-compare-relation-boolean.js +++ b/tests/lib/rules/no-compare-relation-boolean.js @@ -45,7 +45,10 @@ ruleTester.run("no-compare-relation-boolean", rule, { // Comparing against something that isn't a boolean literal is fine "assert.equal(a > b, 1);", - "assert.equal(a > b, c);" + "assert.equal(a > b, c);", + + // Not enough arguments + "assert.strictEqual();" ].map(code => testUtils.wrapInTest(code)), invalid: [ From 549422f3ad9d75f3125365af6d561bc732dc1522 Mon Sep 17 00:00:00 2001 From: Derek Wickern Date: Mon, 6 Jun 2022 15:47:11 -0700 Subject: [PATCH 2/3] add test for 1-arg call --- tests/lib/rules/no-compare-relation-boolean.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/lib/rules/no-compare-relation-boolean.js b/tests/lib/rules/no-compare-relation-boolean.js index e9c848b8..b6689225 100644 --- a/tests/lib/rules/no-compare-relation-boolean.js +++ b/tests/lib/rules/no-compare-relation-boolean.js @@ -48,7 +48,8 @@ ruleTester.run("no-compare-relation-boolean", rule, { "assert.equal(a > b, c);", // Not enough arguments - "assert.strictEqual();" + "assert.strictEqual();", + "assert.strictEqual(a);" ].map(code => testUtils.wrapInTest(code)), invalid: [ From b024a1354b8b83fd79313d9aceee8cc64624f6fd Mon Sep 17 00:00:00 2001 From: Derek Wickern Date: Tue, 7 Jun 2022 08:57:48 -0700 Subject: [PATCH 3/3] fix test failures --- lib/rules/no-compare-relation-boolean.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/rules/no-compare-relation-boolean.js b/lib/rules/no-compare-relation-boolean.js index 046cdd46..d63a8f59 100644 --- a/lib/rules/no-compare-relation-boolean.js +++ b/lib/rules/no-compare-relation-boolean.js @@ -86,7 +86,7 @@ module.exports = { function checkAssertArguments(callExprNode) { const args = [...callExprNode.arguments]; - if (args.length <= 2) { + if (args.length < 2) { return; }