Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any plans migrating to React 18+? #351

Closed
KieranTH opened this issue Apr 29, 2024 · 2 comments · Fixed by #252
Closed

Any plans migrating to React 18+? #351

KieranTH opened this issue Apr 29, 2024 · 2 comments · Fixed by #252
Labels
enhancement New feature or request

Comments

@KieranTH
Copy link

Is your feature request related to a problem? Please describe.

Migration to React 18.

Describe the solution you'd like

A plan on whether React 18 migration should attempted.

I've spent the past day trying to migrate Player to React 18 myself in a fork. There are a few old and outdated dependencies currently being used. I imagine there would be substantial effort to continue this migration.

It seems like a few of these outdated dependencies are from the docs site, whilst the main ones attached to Player itself are React, React-DOM and Typescript (As my current depth of changes have found anyway) - which is also quite an undertaking.

As other projects by the community proceed to use newer versions of React, the peer dependencies attached to Player will just cause Node install errors.

Are there any thoughts on this and any worries / concerns?

Cheers!

@KieranTH KieranTH added the enhancement New feature or request label Apr 29, 2024
@adierkens
Copy link
Member

adierkens commented Apr 29, 2024

Most of our major refactors (including the update to react@18) are staged on the bazel-6 branch #252

There were some pretty major changes to our builds (we may also go straight to bazel 7 now), in addition to updating all of the dependencies across the project to the latest. We're still waiting on a few other updates (android & jvm builds, etc) in order to get canary builds out to start testing, but we are working towards releasing support for react@18 soon.

@KieranTH
Copy link
Author

Most of our major refactors (including the update to react@18) are staged on the bazel-6 branch #252

There were some pretty major changes to our builds (we may also go straight to bazel 7 now), in addition to updating all of the dependencies across the project to the latest. We're still waiting on a few other updates (android & jvm builds, etc) in order to get canary builds out to start testing, but we are working towards releasing support for react@18 soon.

Appreciate the quick response. Glad to hear!

I'll keep an eye out for those canary versions :)

@KetanReddy KetanReddy linked a pull request Jul 11, 2024 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants