Error thrown while generating error message for missing asset-type

[adierkens]

Debugging an issue with assets missing from the registry, and the fuse search is obfuscating the real error message

[KetanReddy]

Huh, that's strange. I'm surprised a test didn't catch that.

[KetanReddy]

I was also surprised that TypeScript didn't flag that as an issue, but it looks like we don't have the check for that turned on. So we should probably enable noUncheckedIndexedAccess

[adierkens]

I was able to determine the root-cause of the original error -- but my guess is that nothing in the registry came up as a similar matching name and it returned undef

I also noticed our bundle size grow ~15kb with the introduction of fuse.js:

https://bundlephobia.com/package/@player-ui/react@0.8.0-next.2	https://bundlephobia.com/package/@player-ui/react@0.8.0-next.4

I would try to find something smaller to replace it with, put it behind a DEBUG flag, or rip it out entirely

[KetanReddy]

Maybe fuzzysort? 5kb isn't bad if we do want to support those kind of suggestions but since we don't really have dev/prod bullds it would have to always get included. https://github.com/farzher/fuzzysort

[adierkens]

We likely don't need a full search library, something that computes the levenshtein distance would be enough to make a suggestion

https://www.npmjs.com/package/leven
https://www.npmjs.com/package/@laboralphy/did-you-mean

[cehan-Chloe]

@adierkens thanks for capturing this issue!
Questions:

1. Could you share the asset info when you debugging the asset missing in registry? I'm surprised that typescript check and test cases didn't capture this issue. Will add new test cases for it.
2. How we check the bundle size before merge pr? https://www.npmjs.com/package/fuse.js?activeTab=readme i was checking the fuse.js but it only has unpacked size

Action item:

1. Replace fuse.js to avoid the bundle size increase
2. Add noUncheckedIndexedAccess
3. Add test cases for this scenario
   I was able to determine the root-cause of the original error -- but my guess is that nothing in the registry came up as a similar matching name and it returned undef

[cehan-Chloe]

ok i'm able to reproduce with the test case below and can confirm it's because no similar type/key name in registry fuse search will return empty array... https://www.fusejs.io/demo.html also tested in their demo page if i use any char like "8" which doesn't exist in any keys.

  const assetDef = {
    asset: {
      id: "bar-id",
      type: "bar",
    },
  } as unknown as AssetType;

  const registry: AssetRegistryType = new Registry([
    [{ type: "foo", key: "foo-key" }, () => <div>foo</div>],
    [{ type: "a", key: "test" }, () => <div>bar</div>],
  ]);

[adierkens]

@cehan-Chloe You can use bundlephobia to check the canary version of the Player packages on your PR (similar to what was done in #432)