Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support >22 args in Scala 3 in Twirl 2.0.5 is a breaking change #801

Closed
dwestheide opened this issue May 31, 2024 · 2 comments
Closed

Support >22 args in Scala 3 in Twirl 2.0.5 is a breaking change #801

dwestheide opened this issue May 31, 2024 · 2 comments

Comments

@dwestheide
Copy link

The support for > 22 args in Scala 3 has been implemented as a breaking change: Where Twirl templates previously were of type TemplateX, for example Template2[Int, HtmlFormat.Appendable], that type is now gone. We have Scala 3 code that deals with multiple templates of the same type, abstracting over the concrete Twirl template. Code like this breaks when upgrading from Twirl 2.0.4 to Twirl 2.0.5. That should not happen with a patch release.

I can probably work around this by using structural typing. Nevertheless, I wanted to address the issue of introducing a breaking change in a patch release. Not sure what the correct way forward is, now that the release is out in the wild, though.

@mkurz
Copy link
Member

mkurz commented May 31, 2024

This will be fixed in Twirl 2.0.6:

@mkurz mkurz closed this as completed May 31, 2024
@dwestheide
Copy link
Author

That's great to hear, thanks a lot for the quick reply. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants