Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rounding error when using gross prices and displaying net prices #536

Open
florianliebig opened this issue Mar 19, 2020 · 2 comments
Open

Comments

@florianliebig
Copy link
Contributor

Q A
issue or Enhancement issue
Version Specific version or SHA of a commit

Actual Behavior

What is the actual behavior?

c94e165 With this commit you changed the rounding of OrderItem Prices

image

It transfers a rounded price into plentymarkets:

E.g. when having an item which has a price of 11.45€ gross:

UVP 11,45€ x 12 = 137,40€

Shopware now calculates like this

11,45 / 1,19 = 9,62184€ rounding to 9,62€
9,62 * 12 = 115,44€ total net cart

  • 1,19 = 137,37€ rounded

In Plentymarkets due to rounding it transfers 137,40.

Expected Behavior

What is the behavior you expect?

Not 100% sure if this needs to be solved by Shopware or it's wrong from plentyconnector. I just would like to know the case in which rounding for transferring the order to plentymarkets is needed.

Steps to Reproduce

I can provide Frontend access to example project if needed.

Possible Solutions

  • Remove rounding again (will test this now)
  • Look at solution in shopware to avoid rounding errors.
@florianliebig
Copy link
Contributor Author

Removing the round(..) solves the issue for this particular problem.

@florianliebig
Copy link
Contributor Author

It seems to conflict with "Grundeinstellungen > Storefront > Warenkorb / Artikeldetails > Netto-Bestellungen konsequent auf 2 Stellen runden"

Which is set to now at our site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant