Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run RN tests post 64bit changes #2

Closed
marafat opened this issue May 31, 2018 · 3 comments
Closed

Run RN tests post 64bit changes #2

marafat opened this issue May 31, 2018 · 3 comments

Comments

@marafat
Copy link
Collaborator

marafat commented May 31, 2018

Need to follow Test your Changes to test the changes made by #1 (64bit support)
@marafat
Copy link
Collaborator Author

marafat commented May 31, 2018

[UPDATE] Just ran e2e tests as noted here. It was a manual test. The scripts builds the lib and facilitate installing both Android and iOS versions for testing.

Results: both apps ran fine. Android had an issue downloading the size of an image (will look into it next). Also, will try to run ci tests.

@marafat
Copy link
Collaborator Author

marafat commented Jun 4, 2018

[UPDATE] Submitted a PR to facebook to be able to run all ci tests

@marafat
Copy link
Collaborator Author

marafat commented Jun 12, 2018

All tests are passing on the facebook PR facebook#19536.

@marafat marafat closed this as completed Jun 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@marafat