Fixed sso provider wrap key null issue #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As far as I can see, still works like charm, no worries! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @Cannonb4ll.
In the last #156 PR. we had a if check
$providerUserEndpointDataWrapKey !== null.Since my own sso provider does not wrap the response in a key like
data. i setSSO_PROVIDER_USER_ENDPOINT_DATA_WRAP_KEY=to empty.but this
$providerUserEndpointDataWrapKeydefaults todataif I setSSO_PROVIDER_USER_ENDPOINT_DATA_WRAP_KEY=null. that's why I pr this fix to the original #156.Can you check this pr with your current sso implementation so it doesn't break existing installations.
Sorry for any inconvenience <3