Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add darkmode to frontend #283

Merged
merged 14 commits into from
Sep 23, 2024
Merged

Conversation

fabiorodriguesroque
Copy link
Contributor

closes #258

@Cannonb4ll
Copy link
Contributor

Nice work! Let me know once it's ready to be tested 🙌

fabiorodriguesroque

This comment was marked as resolved.

@fabiorodriguesroque fabiorodriguesroque marked this pull request as ready for review September 21, 2024 15:24
@fabiorodriguesroque
Copy link
Contributor Author

fabiorodriguesroque commented Sep 21, 2024

@Cannonb4ll ready to review, I've just mentioned the problem with bg-yellow on private notes,.

This PR doesn't include any button to switch mode, but it's synced with filament panel, should I create a toggle for public view?

Thanks.

@Cannonb4ll
Copy link
Contributor

Nice work! Excellent💙

Yes, a toggle button on the frontend would be very welcome if possible.

Otherwise, I can add that later too💪

@fabiorodriguesroque
Copy link
Contributor Author

@Cannonb4ll toggle added to public view!

@Cannonb4ll Cannonb4ll merged commit 2366006 into ploi:main Sep 23, 2024
4 checks passed
@Cannonb4ll
Copy link
Contributor

Works beautifully 🙌 Thank you so much! 😍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add darkmode to frontend
2 participants