Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Barceloneta and Plone templates Bootstrap 4 compatible #3040

Closed
5 of 8 tasks
MrTango opened this issue Feb 11, 2020 · 1 comment
Closed
5 of 8 tasks

Make Barceloneta and Plone templates Bootstrap 4 compatible #3040

MrTango opened this issue Feb 11, 2020 · 1 comment

Comments

@MrTango
Copy link
Contributor

MrTango commented Feb 11, 2020

part of PLIP: #2967

Barceloneta Theme

  • convert less to sass
  • update compile mechanism for sass
  • use standard Diazo replace/before/after rules to get content and portlet columns
  • define boostrap grid css classes in external xsl file which get's included in rule.xml

Templates to update

List (work in progress) of Packages / Views / Templates to touch: https://docs.google.com/spreadsheets/d/15C0YOsW2cxafM1G8zyHHNsNSJF5hZto6jqpB7ymbE0U

How we will update the templates

We will fix update the templates in all packages for Plone 6, because this will be breaking themes and maybe javascript. To make it possible to use it in Plone 5 already, we will provide overrides inside plonetheme.barceloneta via jbot. The overrides will be only applied for Plone < 6.
The overrides we will need at least for templates in CMFPlone like the controlpanels. Some packages might just get a majaor release and can be still used in Plone 5 but will not be used in Plone < 6 by default.

@agitator
Copy link
Member

@MrTango could you compare with https://github.com/plone/plone.app.z3cform/tree/bootstrap4/plone/app/z3cform/templates and check what's still missing?

@MrTango MrTango closed this as completed Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants