Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Should we use prerelease versions?" doesn't parse response well #47

Closed
davisagli opened this issue Nov 7, 2024 · 4 comments · Fixed by #61
Closed

"Should we use prerelease versions?" doesn't parse response well #47

davisagli opened this issue Nov 7, 2024 · 4 comments · Fixed by #61
Labels
01 type: bug something does not work

Comments

@davisagli
Copy link
Member

If I type "y" for the "Should we use prerelease versions?" prompt, it still doesn't use prerelease versions. It only does this if I type "Yes"

@davisagli davisagli added the 01 type: bug something does not work label Nov 7, 2024
@stevepiercy
Copy link
Contributor

This bit me, too. i lazy. n type y

@davisagli
Copy link
Member Author

It's also a bit misleading because currently it influences the default choice of Plone version, but not the default choice of Volto version

@stevepiercy
Copy link
Contributor

Along with this UI/UX update, there are two other things that bug me, and I don't know whether to pile on this issue or create new ones, or whether to file issues in this repo or the templates repo.

  • Hyphenate "add-on"
  • Use sentence case in prompts instead of Word Case. The latter feels a wee bit shouty.

@davisagli
Copy link
Member Author

@stevepiercy Let's handle that separately because the prompt text itself is in cookieplone-templates, unlike the code that handles parsing this particular response. You'll find the prompts in the cookiecutter.json files in cookieplone-templates.

To test changes with a local clone of the templates, you can run COOKIEPLONE_REPOSITORY=~/path/to/cookieplone-templates uvx cookieplone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
01 type: bug something does not work
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants