Validate imported field values

news/38.bugfix

@@ -0,0 +1,2 @@
+validate imported field values
+[petschki]

plone/app/registry/exportimport/handler.py

@@ -285,6 +285,9 @@ def importRecord(self, node):
         if value is _marker:
             value = field.default
             value_purge = True
+        else:
+            # validate incoming value
+            field.validate(value)
 
         if existing_record is not None:
             if change_field:

plone/app/registry/tests/test_exportimport.py

@@ -14,13 +14,14 @@
 from plone.registry.interfaces import IRegistry
 from plone.supermodel.utils import prettyXML
 from plone.testing import zca
-from Products.GenericSetup.tests.common import DummyImportContext as BaseDummyImportContext
+from Products.GenericSetup.tests.common import DummyImportContext as BaseDummyImportContext  # noqa
 from Products.GenericSetup.tests.common import DummyExportContext
 from zope.component import provideUtility
 from zope.configuration import xmlconfig
 from zope.interface import alsoProvides
 
 import unittest
+import zope.schema
 
 
 configuration = """\
@@ -393,6 +394,29 @@ def test_import_value_only(self):
             self.registry['test.export.simple']
         )
 
+    def test_import_value_validation(self):
+        xml = """\
+<registry>
+    <record name="test.export.simple">
+        <value></value>
+    </record>
+</registry>
+"""
+        context = DummyImportContext(self.site, purge=False)
+        context._files = {'registry.xml': xml}
+
+        self.registry.records['test.export.simple'] = \
+            Record(field.TextLine(title=u"Simple record", default=u"N/A"),
+                   value=u"Sample value")
+
+        try:
+            importRegistry(context)
+        except zope.schema._bootstrapinterfaces.RequiredMissing:
+            # this should raise RequiredMissing
+            pass
+        else:
+            self.fail()
+
     def test_import_value_only_condition_installed(self):
         xml = """\
 <registry>